Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phaser: with parallel set_phase() #611

Closed
jbqubit opened this issue Nov 9, 2016 · 4 comments
Closed

phaser: with parallel set_phase() #611

jbqubit opened this issue Nov 9, 2016 · 4 comments
Assignees
Labels
area:sawg smart arbitrary waveform generator (f.k.a. phaser) state:waiting

Comments

@jbqubit
Copy link
Contributor

jbqubit commented Nov 9, 2016

using phaser branch, commit b14fcd4

Following produces phase-locked sinusoids with a phase offset of 2pi*0.2 rad. Expectation is phase offset of 0 rad.

from artiq.experiment import *


class SAWGTest(EnvExperiment):
    def build(self):
        self.setattr_device("core")
        self.setattr_device("led")
        self.setattr_device("ttl_sma")

        self.setattr_device("sawg0")
        self.setattr_device("sawg1")

    @kernel
    def run(self):
        self.core.break_realtime()
        self.ttl_sma.output()
        delay(1*ms)

        v = 1.0
        f = 100*MHz

        self.sawg0.set_amplitude(v)
        self.sawg0.set_frequency(f)
        self.sawg1.set_amplitude(v)
        self.sawg1.set_frequency(f)

        with parallel:
            self.sawg0.set_phase(0.0)
            self.sawg0.set_phase(0.0)
@jbqubit jbqubit changed the title phaser: with parallel set_phase() not aligned phaser: with parallel set_phase() Nov 9, 2016
@jordens
Copy link
Member

jordens commented Nov 9, 2016

I don't understand your logic behind the reasoning of what you expect.
All set_*() ops are zero-duration.
Please check your code and verify that you want to set the same phase twice on the same channel at the same time.

@jordens jordens added the area:sawg smart arbitrary waveform generator (f.k.a. phaser) label Nov 9, 2016
@jordens jordens self-assigned this Nov 9, 2016
@jordens
Copy link
Member

jordens commented Nov 9, 2016

Oh and please stick with the earlier know working commits, i.e. https://github.com/m-labs/artiq/tree/c428800caf52a77a22a9be0d967715cccb4e0b63

@jordens
Copy link
Member

jordens commented Nov 13, 2016

@jbqubit ping

@jordens
Copy link
Member

jordens commented Jan 26, 2017

no response

@jordens jordens closed this as completed Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sawg smart arbitrary waveform generator (f.k.a. phaser) state:waiting
Projects
None yet
Development

No branches or pull requests

2 participants