oh-my-zsh: add share dir to pathsToLink #21957
Conversation
|
@kjanosz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scolobb, @NeQuissimus and @grahamc to be potential reviewers. |
| @@ -15,6 +15,8 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1adgj0p4c8aq9rpkv33k8ra69922vfkjw63b666i66v6zr0s8znp"; | |||
| }; | |||
|
|
|||
| environment.pathsToLink = [ "/share/oh-my-zsh" ]; | |||
There was a problem hiding this comment.
What does this give us?
I haven't found anything looking like a doc for this attribute :-(
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, nice search engine, didn't know it existed, thanks a lot!
Your change seems reasonable to me.
| @@ -15,6 +15,8 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1adgj0p4c8aq9rpkv33k8ra69922vfkjw63b666i66v6zr0s8znp"; | |||
| }; | |||
|
|
|||
| environment.pathsToLink = [ "/share/oh-my-zsh" ]; | |||
There was a problem hiding this comment.
|
Note that I removed the |
|
My apologies then - I have this line in private module config and didn't actually fully check that in package |
|
No worries, that's why I went to build it myself. |
Motivation for this change
Some window/desktop managers do not add
sharedirectory or do it selectively.Without it
oh-my-zshis not linked to/run/current-system/sw/share, which then makes it harder to set$ZSHvariable in.zshrcThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)