Tweak OpenSSL docs #3910
Merged
Tweak OpenSSL docs #3910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Jan 17, 2017
| # puts "got client" | ||
| # puts "Got client" | ||
| # | ||
| # # Bytes is an alias for Slice(UInt8) |
There was a problem hiding this comment.
I would remove this clarification. If it is not clear what Bytes is the issue is with the name and should be addressed somewhere else I think. Otherwise we would need to clarify this in every usage.
There was a problem hiding this comment.
Yep, I wasn't sure about that remark either, it's good to have another pair of eyes watchin' :)
Sija
force-pushed
the
tweak-openssl-docs
branch
from
e74b9f8
to
f15cf79
Compare
|
Merged, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several small tweaks to
OpenSSLdocs:Slice(UInt8)->BytesWhile editing I noticed that
OpenSSL::SSL::Socketgets linked toSocketinstead which looks like a bug to me.