Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.13 -> 0.0.1 #22158

Merged
merged 1 commit into from Jan 26, 2017
Merged

discord: 0.0.13 -> 0.0.1 #22158

merged 1 commit into from Jan 26, 2017

Conversation

MP2E
Copy link

@MP2E MP2E commented Jan 26, 2017 •
edited

Despite the version number confusion, this is a new version of
discord-canary, but since the build is now public/official, the version
number has been reset and the canary suffix has been dropped.

Note that this means that the executable has been renamed from
DiscordCanary to Discord

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • (nothing depends on discord) Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

discord: 0.0.13 -> 0.0.1
4b159c2 
Despite the version number confusion, this is a new version of
discord-canary, but since the build is now public/official, the version
number has been reset and the canary suffix has been dropped.

Note that this means that the executable has been renamed from
DiscordCanary to Discord
dancek
dancek approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@dancek dancek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about the version number inconsistency, but otherwise looks good to me.

@globin globin merged commit 2f367e0 into NixOS:master Jan 26, 2017
@globin
Copy link
Member

globin commented Jan 26, 2017

😢 that version change..

@MP2E
Copy link
Author

MP2E commented Jan 26, 2017 •
edited

Version change was upstream, unfortunately. Hopefully they'll be consistent from here on out :)

thanks for the merge !

@MP2E MP2E deleted the discord_update branch January 26, 2017 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancek dancek dancek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MP2E @globin @dancek