pgroonga: init at 1.1.9 #22165

DerTim1 · 2017-01-26T07:21:15Z

Motivation for this change

Add Postgresql Plugin pgroonga.

Can e.g. be used with:

services.postgresql = {
    enable = true;
    package = pkgs.postgresql95;
    dataDir = "/var/db/postgresql";
    extraPlugins = [ pkgs.pgroonga ];
  };

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[-] Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

grahamc · 2017-01-27T01:45:12Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+  '';
+
+  meta = with stdenv.lib; {
+    description = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";


This should be broken out in to a shorter description and longer longDescription:https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Thanks for your advice. I've fixed this and have done a rebase.

grahamc · 2017-01-27T12:01:26Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+    longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
+    homepage = https://pgroonga.github.io/;
+    license = licenses.postgresql;
+    maintainers = [ ];


Can you make yourself a maintainer?

I'm not sure if I using this package in production, so I think I'm not a capable maintainer.

grahamc · 2017-01-27T12:05:04Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+    description = "Is a PostgreSQL extension to use Groonga as the index";
+    longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
+    homepage = https://pgroonga.github.io/;
+    license = licenses.postgresql;


This is actually licensed under the GNU Lesser General Public License version 2.1. Not sure what to do, since https://github.com/NixOS/nixpkgs/blob/master/lib/licenses.nix doesn't have that one...

Are you sure? See licence section: https://pgroonga.github.io/

PGroonga is released under PostgreSQL license that is similar to BSD license and MIT license.

grahamc

LGTM but would like someone to take a look. @joachifm maybe?

joachifm

I don't know anything abou this software, but added a few superficial nits ...

joachifm · 2017-01-27T12:19:58Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

@@ -0,0 +1,29 @@
+{ stdenv, pkgs, fetchurl, pkgconfig, postgresql, libmsgpack, groonga }:


Please remove pkgs

joachifm · 2017-01-27T12:20:58Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+  '';
+
+  meta = with stdenv.lib; {
+    description = "Is a PostgreSQL extension to use Groonga as the index";


"Is a" -> "A"

joachifm · 2017-01-27T12:23:14Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+
+  meta = with stdenv.lib; {
+    description = "Is a PostgreSQL extension to use Groonga as the index";
+    longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";


By "alphabet and digit" do you mean ascii or alphanumeric perhaps?

This is the official description from PGroonga...

I see. I guess it's referring to alphabetic vs logographic (or whatever its called) writing systems. Anyway, it's not all that important.

DerTim1 · 2017-01-27T13:08:13Z

Thanks for comments, I've rebased again.

rasendubi · 2017-01-30T20:13:43Z

pkgs/servers/sql/postgresql/pgroonga/default.nix

+    longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
+    homepage = https://pgroonga.github.io/;
+    license = licenses.postgresql;
+    maintainers = [ ];


@DerTim1, would you like to maintain the package?

Ok, persuaded...

grahamc reviewed Jan 27, 2017

View reviewed changes

joachifm reviewed Jan 27, 2017

View reviewed changes

rasendubi reviewed Jan 30, 2017

View reviewed changes

pgroonga: init at 1.1.9

be8790e

fpletz merged commit e2bf041 into NixOS:master Jan 31, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pgroonga: init at 1.1.9 #22165

pgroonga: init at 1.1.9 #22165

DerTim1 commented Jan 26, 2017 •

edited

Loading

grahamc Jan 27, 2017

DerTim1 Jan 27, 2017

grahamc Jan 27, 2017

DerTim1 Jan 27, 2017

grahamc Jan 27, 2017

DerTim1 Jan 27, 2017 •

edited

Loading

grahamc left a comment

joachifm left a comment

joachifm Jan 27, 2017

joachifm Jan 27, 2017

joachifm Jan 27, 2017

DerTim1 Jan 27, 2017

joachifm Jan 27, 2017

DerTim1 commented Jan 27, 2017

rasendubi Jan 30, 2017

DerTim1 Jan 31, 2017

		@@ -0,0 +1,29 @@
		{ stdenv, pkgs, fetchurl, pkgconfig, postgresql, libmsgpack, groonga }:

pgroonga: init at 1.1.9 #22165

pgroonga: init at 1.1.9 #22165

Conversation

DerTim1 commented Jan 26, 2017 • edited Loading

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DerTim1 Jan 27, 2017 • edited Loading

Choose a reason for hiding this comment

grahamc left a comment

Choose a reason for hiding this comment

joachifm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DerTim1 commented Jan 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DerTim1 commented Jan 26, 2017 •

edited

Loading

DerTim1 Jan 27, 2017 •

edited

Loading