Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgroonga: init at 1.1.9 #22165

Merged
merged 1 commit into from Jan 31, 2017
Merged

pgroonga: init at 1.1.9 #22165

merged 1 commit into from Jan 31, 2017

Conversation

DerTim1
Copy link

@DerTim1 DerTim1 commented Jan 26, 2017 •
edited

Motivation for this change

Add Postgresql Plugin pgroonga.

Can e.g. be used with:

services.postgresql = {
    enable = true;
    package = pkgs.postgresql95;
    dataDir = "/var/db/postgresql";
    extraPlugins = [ pkgs.pgroonga ];
  };
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [-] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

grahamc
grahamc reviewed Jan 27, 2017
View reviewed changes
pkgs/servers/sql/postgresql/pgroonga/default.nix
'';

meta = with stdenv.lib; {
description = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be broken out in to a shorter description and longer longDescription:https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. I've fixed this and have done a rebase.

grahamc
grahamc reviewed Jan 27, 2017
View reviewed changes
pkgs/servers/sql/postgresql/pgroonga/default.nix
longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
homepage = https://pgroonga.github.io/;
license = licenses.postgresql;
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make yourself a maintainer?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I using this package in production, so I think I'm not a capable maintainer.

grahamc
grahamc reviewed Jan 27, 2017
View reviewed changes
pkgs/servers/sql/postgresql/pgroonga/default.nix
description = "Is a PostgreSQL extension to use Groonga as the index";
longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
homepage = https://pgroonga.github.io/;
license = licenses.postgresql;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually licensed under the GNU Lesser General Public License version 2.1. Not sure what to do, since https://github.com/NixOS/nixpkgs/blob/master/lib/licenses.nix doesn't have that one...

Copy link
Author

@DerTim1 DerTim1 Jan 27, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? See licence section: https://pgroonga.github.io/

PGroonga is released under PostgreSQL license that is similar to BSD license and MIT license.

grahamc
grahamc reviewed Jan 27, 2017
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like someone to take a look. @joachifm maybe?

joachifm
joachifm reviewed Jan 27, 2017
View reviewed changes
Copy link
Contributor

@joachifm joachifm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything abou this software, but added a few superficial nits ...

pkgs/servers/sql/postgresql/pgroonga/default.nix
@@ -0,0 +1,29 @@
{ stdenv, pkgs, fetchurl, pkgconfig, postgresql, libmsgpack, groonga }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove pkgs

pkgs/servers/sql/postgresql/pgroonga/default.nix
'';

meta = with stdenv.lib; {
description = "Is a PostgreSQL extension to use Groonga as the index";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Is a" -> "A"

pkgs/servers/sql/postgresql/pgroonga/default.nix

meta = with stdenv.lib; {
description = "Is a PostgreSQL extension to use Groonga as the index";
longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "alphabet and digit" do you mean ascii or alphanumeric perhaps?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the official description from PGroonga...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I guess it's referring to alphabetic vs logographic (or whatever its called) writing systems. Anyway, it's not all that important.

@DerTim1
Copy link
Author

DerTim1 commented Jan 27, 2017

Thanks for comments, I've rebased again.

rasendubi
rasendubi reviewed Jan 30, 2017
View reviewed changes
pkgs/servers/sql/postgresql/pgroonga/default.nix
longDescription = "PGroonga is a PostgreSQL extension to use Groonga as the index. PostgreSQL supports full text search against languages that use only alphabet and digit. It means that PostgreSQL doesn't support full text search against Japanese, Chinese and so on. You can use super fast full text search feature against all languages by installing PGroonga into your PostgreSQL.";
homepage = https://pgroonga.github.io/;
license = licenses.postgresql;
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DerTim1, would you like to maintain the package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, persuaded...

@fpletz fpletz merged commit e2bf041 into NixOS:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@grahamc grahamc grahamc left review comments

@rasendubi rasendubi rasendubi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DerTim1 @joachifm @grahamc @rasendubi @fpletz