Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mwprocapture: init at 1.2.3269 #22160

Merged
merged 3 commits into from Feb 18, 2017
Merged

mwprocapture: init at 1.2.3269 #22160

merged 3 commits into from Feb 18, 2017

Conversation

MP2E
Copy link

@MP2E MP2E commented Jan 26, 2017

Looking for feedback as this is my first NixOS kernel module package.

a driver for the Magewell Pro Capture family of pci-e cards.
Also includes the mwcap-info and mwcap-control utilities, for
changing pixel format settings on the card, among other things.
Uses v4l2 for video output, alsa/pulse for audio output

System configuration option to enable package:
hardware.mwProCapture.enable = true;

Motivation for this change

This allows anyone who owns a pci-e Magewell capture device to capture video or stream and may provide a good base for future capture card related packaging (which is admittedly niche)

Things done

Substituted all hardcoded paths with paths pointing to the correct nixpkgs store output
Executables are patchelf'd and all dependencies are satisfied.
Module has been tested with the 4.9 kernel series and works well

Things to possibly be done

Package the quickstart guide and the users manual somewhere as documentation? Currently nothing is done with these

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

a driver for the Magewell Pro Capture family of pci-e cards.
Also includes the mwcap-info and mwcap-control utilities, for
changing pixel format settings on the card, among other things.
Uses v4l2 for video output, alsa/pulse for audio output

System configuration option to enable package:
  hardware.mwProCapture.enable = true;

let
bits =
if stdenv.system == "x86_64-linux" then "64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also stdenv.is64bit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing that out!

Cray Elliott added 2 commits February 4, 2017 22:25
move configuration settings to boot.extraModProbeConfig, removed
$out/modprobe.conf
@joachifm joachifm merged commit 5e0b978 into NixOS:master Feb 18, 2017
@MP2E
Copy link
Author

MP2E commented Feb 19, 2017

thank you!

@MP2E MP2E deleted the mwprocapture_wip branch February 19, 2017 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants