rambox: 0.4.5 -> 0.5.2 #22168
rambox: 0.4.5 -> 0.5.2 #22168
Conversation
|
@phryneas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gnidorah and @NeQuissimus to be potential reviewers. |
There was a problem hiding this comment.
exec = name; to exec = "rambox"; at https://github.com/phryneas/nixpkgs/blob/947d862f92e1b5b1ce0be111968ef63d507d51cf/pkgs/applications/networking/instant-messengers/rambox/default.nix#L18 so menu item will work
| @@ -42,19 +42,19 @@ in stdenv.mkDerivation rec { | |||
| ]; | |||
|
|
|||
| installPhase = '' | |||
| patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" Rambox | |||
| patchelf --set-rpath "$out/share/rambox:${stdenv.lib.makeLibraryPath deps}" Rambox | |||
| patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" rambox | |||
There was a problem hiding this comment.
@phryneas Thanks for being faster than me! :) You would also like to change exec = name; to exec = "rambox"; at https://github.com/phryneas/nixpkgs/blob/947d862f92e1b5b1ce0be111968ef63d507d51cf/pkgs/applications/networking/instant-messengers/rambox/default.nix#L18 so menu item will work
There was a problem hiding this comment.
will do that. and of course, I forgot to create a branch for the pull request, so I'll have to open a second pull request in a second :)
There was a problem hiding this comment.
@phryneas Nix people will surely take the change from your master as well
There was a problem hiding this comment.
Yeah, noticed that a moment later, too.
I added the changed "exec" line.
There was a problem hiding this comment.
@phryneas
Hi. There is now a new hotfix release 0.5.3 https://github.com/saenzramiro/rambox/releases/ which corrects the login issue some people may have on 0.5.2 if they were using 0.4.5 and lower prior https://github.com/saenzramiro/rambox/issues/622
Could you please update your pull request to bring 0.5.3? Or if you have no time, I may do this instead, but since I'm not a part of nixpkgs, you will need to close this PR, so I will open a new one for 0.5.3 instead
|
@gnidorah: I won't be near a nixos machine until monday, so I'll close this to allow you to send a new PR. |
ghost
mentioned this pull request
|
@phryneas Done, thanks! I've preserved you as commit author ;-) |
|
Very cool, thanks ^^ |
Motivation for this change
version bump, new checksums.
also, the binary was renamed in the new download (from Rambox to rambox).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)