tsearch-extras: init at 0.2 #22166
tsearch-extras: init at 0.2 #22166
Conversation
|
Rebased (removed dot at the end of meta.description) |
| src = fetchFromGitHub { | ||
| owner = "zulip"; | ||
| repo = "tsearch_extras"; | ||
| rev = "560e6748bd7cfcea98efd412ca80f08cff890f9c"; |
There was a problem hiding this comment.
Please consider rev = version
| @@ -0,0 +1,28 @@ | |||
| { stdenv, pkgs, fetchFromGitHub, pkgconfig, postgresql }: | |||
There was a problem hiding this comment.
Please do not pass in all of pkgs; only stuff that's actually used.
| sha256 = "1ivg9zn7f1ks31ixxwywifwhzxn6py8s5ky1djyxnb0s60zckfjg"; | ||
| }; | ||
|
|
||
| buildInputs = [ postgresql pkgconfig ]; |
There was a problem hiding this comment.
pkgconfig can be specified in nativeBuildInputs
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "The package provides a few PostgreSQL functions that allow you to get at lower-level data about full text search"; |
There was a problem hiding this comment.
Please leave out "The package provides".
There was a problem hiding this comment.
Also consider that the description must be short and to the point so that they render nicely in console output and the like; details go in longDescription.
| description = "The package provides a few PostgreSQL functions that allow you to get at lower-level data about full text search"; | ||
| homepage = https://github.com/zulip/tsearch_extras/; | ||
| license = licenses.postgresql; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
Please specify yourself as maintainer or leave this out; the empty list is the default.
|
Thanks @joachifm for your advice and review. New commit is pushed. |
| description = "Provides a few PostgreSQL functions for a lower-level data full text search."; | ||
| homepage = https://github.com/zulip/tsearch_extras/; | ||
| license = licenses.postgresql; | ||
| maintainers = [ DerTim1 ]; |
There was a problem hiding this comment.
I suspect this'll fail to evaluate, probably needs either with maintainers or [ maintainers.DerTim1 ].
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Provides a few PostgreSQL functions for a lower-level data full text search."; |
There was a problem hiding this comment.
Please remove trailing punctuation, per the guidelines.
|
Thanks, I'm still doing the same mistakes evreytime. |
|
Thank you |
Motivation for this change
Add Postgresql Plugin tsearch_extras (e.g. necessary for zulip)
Can e.g. be used with:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)