Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcs: init at 4.8.0 #22173

Merged
merged 2 commits into from Feb 4, 2017
Merged

gcs: init at 4.8.0 #22173

merged 2 commits into from Feb 4, 2017

Conversation

gkleen
Copy link
Contributor

@gkleen gkleen commented Jan 26, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@gkleen
Copy link
Contributor Author

gkleen commented Jan 26, 2017

Build failure seems unrelated to changes introduced by this pr

@LnL7
Copy link
Member

LnL7 commented Feb 1, 2017

The darwin build failed for me.

unpacking sources
unpacking source archive /nix/store/ikh7g99194iwbwkh0rw0qnd1fsq12b79-gcs-4.8.0-src
source root is gcs-4.8.0-src
patching sources
configuring
no configure script, doing nothing
building
Buildfile: /private/var/folders/qv/5k4lhv3n1hg2jk29cj3smtp00000gn/T/nix-build-gcs-4.8.0.drv-0/gcs-4.8.0-src/apple_stubs/build.xml

clean:

stubs:
    [mkdir] Created dir: /private/var/folders/qv/5k4lhv3n1hg2jk29cj3smtp00000gn/T/nix-build-gcs-4.8.0.drv-0/gcs-4.8.0-src/apple_stubs/ant_build
    [javac] Compiling 37 source files to /private/var/folders/qv/5k4lhv3n1hg2jk29cj3smtp00000gn/T/nix-build-gcs-4.8.0.drv-0/gcs-4.8.0-src/apple_stubs/ant_build
    [javac] javac: invalid target release: 1.8
    [javac] Usage: javac <options> <source files>
    [javac] use -help for a list of possible options

BUILD FAILED
/private/var/folders/qv/5k4lhv3n1hg2jk29cj3smtp00000gn/T/nix-build-gcs-4.8.0.drv-0/gcs-4.8.0-src/apple_stubs/build.xml:20: Compile failed; see the compiler error output for details.

Total time: 0 seconds
builder for ‘/nix/store/da1hcq9w7ziawbzc7i5zd09a6ls5lw8q-gcs-4.8.0.drv’ failed with exit code 1

@gkleen
Copy link
Contributor Author

gkleen commented Feb 3, 2017

Build failure seems to be caused by jdk and jre defaulting to jdk7 and jre7 on darwin.
We now demand the 1.8 versions of jdk and jre explicitly

@joachifm joachifm merged commit 913c5b2 into NixOS:master Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkleen @LnL7 @joachifm