Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trim trailing whitespace in patch files #21844

Merged
merged 1 commit into from Jan 12, 2017
Merged

Do not trim trailing whitespace in patch files #21844

merged 1 commit into from Jan 12, 2017

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Jan 12, 2017

Motivation for this change

The automatic removal of trailing whitespace can cause trouble when working on a patch file. It can lead to hunks not being applied anymore.

This change switches it off for files ending in .diff and .patch.

@mention-bot
Copy link

@johbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 to be a potential reviewer.

@Mic92 Mic92 merged commit fa51c2c into NixOS:master Jan 12, 2017
@Mic92
Copy link
Member

Mic92 commented Jan 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johbo @mention-bot @Mic92