Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: 2.4.0 #21419

Merged
merged 1 commit into from Dec 27, 2016
Merged

ruby: 2.4.0 #21419

merged 1 commit into from Dec 27, 2016

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Dec 26, 2016 •
edited

Motivation for this change
  • Made an updated rvm-patchsets fork until upstream is fixed.
  • Fixed the docSupport option, so a build with docSupport = false is now 19MB instead of 85MB and builds faster.
  • Added the 2.4.0 version, but it's not the default ruby yet, would recommend waiting a few days for stability.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@manveru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vrthra, @cstrahan and @pikajude to be potential reviewers.

@manveru
Copy link
Contributor Author

manveru commented Dec 26, 2016

@zimbatm also pinging you, just in case

@cstrahan
Copy link
Contributor

Fixed the docSupport option, so a build with docSupport = false is now 19MB instead of 85MB and builds faster.

Awesome!

@Mic92
Copy link
Member

Mic92 commented Dec 26, 2016

Would it make sense to have a dedicated doc output here?

@manveru
Copy link
Contributor Author

manveru commented Dec 26, 2016

After running nox-review over night, I found a failure in bezel, which doesn't seem related to this change. Bezel uses buildFHSUserEnv which depends on Ruby for FFI via Fiddle. This in turn tries to mount /sys to a build dir, which only works as root. That seems related to #19047 and isn't something I can fix.

Not sure how to skip this package in nox-review.

@Mic92
Copy link
Member

Mic92 commented Dec 26, 2016 •
edited

@manveru Bezel was broken before, I think. This should not be a blocker for a ruby update. I currently work on a replacement of buildFHSUserEnv, which allows to skip /sys.

zimbatm
zimbatm approved these changes Dec 27, 2016
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple outputs would be better for the docs but since this fixes an existing flag it's not a blocker

@zimbatm zimbatm merged commit df5f880 into NixOS:master Dec 27, 2016
@manveru
Copy link
Contributor Author

manveru commented Dec 29, 2016

https://github.com/skaes/rvm-patchsets/tree/master/patches/ruby/2.4/head/railsexpress has been added by skaes, so we could switch to the original again.

@manveru manveru deleted the ruby-2-4 branch November 30, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manveru @mention-bot @cstrahan @Mic92 @zimbatm