hydra: remove any patches from aws-sdk-cpp #21418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
215b1e5 added a patch to aws-sdk-cpp which does not apply to the override in hydra's aws-sdk-cpp, since it is an older version fetched from edolstra/aws-sdk-cpp which does not contain `aws-cpp-sdk-s3-encryption/CMakeLists.txt` Signed-off-by: Maximilian Güntner <code@klandest.in>
|
@mguentner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @vcunat and @abbradar to be potential reviewers. |
|
Closing due to 3e84523 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
215b1e5 added a patch to aws-sdk-cpp which does not
apply to the override in hydra's aws-sdk-cpp, since it
is an older version fetched from edolstra/aws-sdk-cpp
which does not contain
aws-cpp-sdk-s3-encryption/CMakeLists.txtThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)