Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving post encryption into plugin. #2604

Merged
merged 2 commits into from
Dec 25, 2016
Merged

Moving post encryption into plugin. #2604

merged 2 commits into from
Dec 25, 2016
+130 −65

Conversation

felixfontein
Copy link
Contributor

Implements part of #1696.

@Kwpolska
Copy link
Member

Meh, I’d prefer to just delete this misfeature here and now. Over 2 years have passed since we deprecated that thing.

@felixfontein
Copy link
Contributor Author

I can live with that, too. Getting it out of post.py is a good start, though, since it shows people who really want to use this (for whatever reason) how they can still do that even though the feature is gone from Nikola.

@felixfontein felixfontein force-pushed the moving-post-encryption-to-plugin branch from facb0e4 to 0f74962 Compare December 25, 2016 18:31
@felixfontein
Copy link
Contributor Author

(Rebased to remove conflicts and get rid of change which was already included in #2607.)

@Kwpolska
Copy link
Member

Why should we help people do outright stupid things?

@felixfontein
Copy link
Contributor Author

Because we allowed to do that in the first place, and we want to avoid backwards-compatibility breaking changes in minor versions?

@Kwpolska
Copy link
Member

We should probably get v8 going already.

Kwpolska
Kwpolska approved these changes Dec 25, 2016
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheesh.

nikola/plugins/misc/post_encryption.py
# OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

"""Render the taxonomy overviews, classification pages and feeds."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@felixfontein felixfontein merged commit 1ac6148 into master Dec 25, 2016
@felixfontein felixfontein deleted the moving-post-encryption-to-plugin branch December 25, 2016 20:00
@felixfontein
Copy link
Contributor Author

Next step: removing that plugin in v8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixfontein @Kwpolska