-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chunk_while not returning results equivalent to MRI ruby 2.3+ (jruby 9.1.6.0) #4410
Comments
Just going to note for anyone who wants to work on this that it is not a 2.4 compat bug but probably a 2.3 one (I did not check earlier). @olbrich I am only mentioning this since 9.1.x of JRuby only supports 2.3 and not 2.4. (9.2.x will support 2.4 specific features). So this is fair game right now if anyone wants to take it on. |
@enebo yeah, it probably is inconsistent with all the MRI rubies that support chunk_while (which I think was introduced in ruby 2.3). |
* update build tools to check ruby 2.4.0 * clean up usage of some newer methods for compatibility with older ruby versions * add notes to readme * ensure we are using jruby that emulates a ruby 2.* series * workaround for jruby bug (see jruby/jruby#4410)
Yep, I'll take a look at this |
@cthulhua If it starts to look like it's a problem with JRuby's Enumerable or "native" bits, let us know. We're still dragging along some not-always-correct Java impls of the core Enumerable logic, and these sorts of things are not uncommon to see. |
It's the same issue with #slice_when that was fixed in a8eff5d Might be worth consolidating the logic |
@cthulhua Good catch...I'll give that a shot. |
Ok, I went with @cthulhua's suggestion and combined slice_when and chunk_while logic. This is now fixed. We may want to look at the Truffle/Rubinius versions of these methods, since we depend on |
Environment
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: