-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
ncurses: Create ABI-version'd libtinfo #21368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @vcunat to be potential reviewers. |
Hmm, buildFHSUserEnv doesn't seem to want to copy the created symlinks to the chroot. |
(works fine, just travis 4mb log limit) |
This is ready now (and still needed), correct? |
Yep! |
Tested on |
c826ec6 breaks Vim. Can you look into this? Possibly we need to separate |
How does it break it? |
http://hydra.nixos.org/build/45535843 Reproducible on my machine. |
Alright, thanks. Will check out. (no pun intended) |
The symlink points to bad target, I believe. It's |
Yeah, the ln call needs to be moved out of the libs loop. Weird it worked
for me. Maybe it was just dumb luck that autoconf resolved it correctly
when I needed it. I'll fix it up tonight.
…On Wed, 28 Dec 2016, 18:07 Vladimír Čunát, ***@***.***> wrote:
The symlink points to bad target, I believe. It's libpanelw.so ATM. I
fail to understand the intention of c826ec6
<c826ec6>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21368 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB2crIJHbe-4EuiX4rYGAQrFtnorE1Ymks5rMhjBgaJpZM4LUfsB>
.
|
|
Hmm, no, bad speculation, it should be always "alphabetical". |
@spacekitteh: so, what was wrong about "cross platform"? (i.e. what that commit was meant to fix?) Otherwise I'd just revert that one. |
Staged: e4f23bc. |
Motivation for this change
Making sure versioned library loads work correctly. Also, the PR works, just travis log length error.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)