AgdaStdlib: v0.12 -> v0.13 #21396
Merged
AgdaStdlib: v0.12 -> v0.13 #21396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laMudri Why should we not merge yet? I don't understand the purpose of 'trivial' version bump PR if it's not to be merged: usually such PRs are done for big proof-of-concept changes... |
|
It's a matter of timing. stdlib v0.13 is supposed to go with Agda 2.5.2, which is not in LTS Haskell (and therefore nixpkgs) yet. I haven't tested stdlib v0.13 with Agda 2.5.1.1, and it doesn't feel right to have them together when each stdlib version is meant for a specific Agda version. stdlib v0.12 is for Agda 2.5.1, and v0.13 is for Agda 2.5.2. |
laMudri
changed the title
|
This should be merged now, with lts-8.0. |
|
@peti, ^, in case you don't get notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Agda will soon be updated to version 2.5.2. This is the version of stdlib to go with it. Other than the timing, this is a standard version bump.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @peti. Agda is a Haskell package. I'm not familiar with how Haskell packages are put on nixpkgs, but they seem to be tied to LTS Haskell, which doesn't have Agda 2.5.2 yet. When it does, this commit should be applied simultaneously.