Fix to concat a union of arrays #3775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... yes, it should work. But I'd like to solve this without adding new public methods to Enumerable and Array. I'll try to think of a solution... |
|
@asterite We can use macro to fix it, but it is very dirty and its error message is worse than now. |
|
@makenowjust I fixed it at the Pointer level :-) |
|
@asterite Wow, amazing! I make |
|
@makenowjust Haha, cool, our minds are in sync! This also happened to me too, in this comment: I was going to ask you to extract a method to increment line numbers, and you did it before me asking it :-P |
|
@asterite The best thing is only one every time, and we aim to reach the best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is cannot be compiled:
This pull request fixes it by adding
Array#concat_toandEnumerable#concat_to, and forwarding fromArray#concatto them.