Prometheus exporters #21422
Prometheus exporters #21422
Conversation
|
@MostAwesomeDude, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
| buildGoPackage rec { | ||
| name = "prometheus_varnish_exporter-${version}"; | ||
| version = "20161126-${stdenv.lib.strings.substring 0 7 rev}"; | ||
| rev = "218cffa79f9b56de6a21a9244d74bdc2ec089473"; |
There was a problem hiding this comment.
Is there a reason not to use a released version here? https://github.com/jonnenauha/prometheus_varnish_exporter/releases
|
|
||
| goPackagePath = "github.com/jonnenauha/prometheus_varnish_exporter"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
fetchFromGitHub is preferred here.
| meta = { | ||
| homepage = "https://github.com/jonnenauha/prometheus_varnish_exporter"; | ||
| description = "Varnish exporter for Prometheus"; | ||
| license = lib.licenses.mit; |
There was a problem hiding this comment.
Do you want to maintain this package?
| exec ${pkgs.prometheus-nginx-exporter}/bin/nginx_exporter \ | ||
| -nginx.scrape_uri '${cfg.scrapeURI}' \ | ||
| -telemetry.address :${toString cfg.port} \ | ||
| ${concatStringsSep " \\\n " cfg.extraFlags} |
There was a problem hiding this comment.
script is unnecessary here. Please use ExecStart directly.
| export PATH=${pkgs.varnish}/bin | ||
| exec ${pkgs.prometheus-varnish-exporter}/bin/prometheus_varnish_exporter \ | ||
| -web.listen-address :${toString cfg.port} \ | ||
| ${concatStringsSep " \\\n " cfg.extraFlags} |
There was a problem hiding this comment.
Same here. The PATH can be extended using the path property.
|
|
||
| buildGoPackage rec { | ||
| name = "prometheus-json-exporter-${version}"; | ||
| version = "20160913-${stdenv.lib.strings.substring 0 7 rev}"; |
There was a problem hiding this comment.
Please use the following version scheme for packages with releases: prometheus-json-exporter-unstable-2016-09-13
| exec ${pkgs.prometheus-json-exporter}/bin/prometheus-json-exporter \ | ||
| --port ${toString cfg.port} \ | ||
| ${cfg.url} ${cfg.configFile} \ | ||
| ${concatStringsSep " \\\n " cfg.extraFlags} |
|
|
||
| goPackagePath = "github.com/kawamuray/prometheus-json-exporter"; | ||
|
|
||
| src = fetchgit { |
MostAwesomeDude
force-pushed
the
prometheus
branch
from
6b009b4
to
ffe806e
Compare
- use ExecStart and ExecReload - add extraFlags
Yeah, I know, it's a git snapshot. Sorry.
|
Cleaned this up a bit and added stuff we had lying around in our fork. |
Motivation for this change
I started using Prometheus recently and I needed to export some stuff.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This all appears to work; https://graphs.matador.cloud/dashboard/db/web-status shows off the nginx and Varnish support, while https://graphs.matador.cloud/dashboard/db/storage-overview uses JSON scraping.