Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmd: Fix build for Darwin #21401

Merged
merged 1 commit into from Dec 25, 2016
Merged

dmd: Fix build for Darwin #21401

merged 1 commit into from Dec 25, 2016

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Dec 25, 2016

Motivation for this change

Noticed that the dmd build was broken on Hydra: http://hydra.nixos.org/build/45029212/nixlog/1

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@johbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vlstill, @BlackEdder and @nckx to be potential reviewers.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 25, 2016
@LnL7 LnL7 merged commit 1d67f6e into NixOS:master Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants