wxMac: fixed main compile on 10.6 #21410
Conversation
|
The attribute is called |
| @@ -1,6 +1,7 @@ | |||
| { stdenv, fetchurl, pkgconfig, gtk2, libXinerama, libSM, libXxf86vm, xf86vidmodeproto | |||
| , gstreamer, gst_plugins_base, GConf, libX11, cairo | |||
| , withMesa ? true, mesa ? null, compat24 ? false, compat26 ? true, unicode ? true, | |||
| , withMesa ? true, mesa ? null, compat24 ? false, compat26 ? true, unicode ? true | |||
| , Carbon ? null, Cocoa ? null, CoreServices | |||
There was a problem hiding this comment.
You didn't add a default value for CoreServices, but this isn't really necessary. If those are not evaluated in the derivation it's fine to pass those around on other platforms.
| @@ -17,7 +18,8 @@ stdenv.mkDerivation rec { | |||
| }; | |||
|
|
|||
| buildInputs = [ gtk2 libXinerama libSM libXxf86vm xf86vidmodeproto gstreamer gst_plugins_base GConf libX11 cairo ] | |||
| ++ optional withMesa mesa; | |||
| ++ optional withMesa mesa | |||
| ++ optionals stdenv.isDarwin [Carbon Cocoa CoreServices]; | |||
There was a problem hiding this comment.
The build still fails for me.
In file included from ./include/wx/mac/private.h:4:
./include/wx/mac/carbon/private.h:1459:9: error: unknown type name 'Cursor'; did you mean 'NSCursor'?
typedef Cursor ClassicCursor;
^~~~~~
NSCursor
./include/wx/defs.h:2508:28: note: 'NSCursor' declared here
DECLARE_WXCOCOA_OBJC_CLASS(NSCursor);
^
./include/wx/defs.h:2486:16: note: expanded from macro 'DECLARE_WXCOCOA_OBJC_CLASS'
typedef struct klass *WX_##klass
^
60 warnings and 1 error generated.
make: *** [Makefile:21236: basedll_encconv.o] Error 1
|
@LnL7 , the build will still fail: the OS X system framework required to build the package is 10.6. The maintainers don't have plans for updating it anytime soon, so for now, the general recommendation people have been making is to download the .framework and pass it as an argument to the configure stage. We could do this, but it'd require we install a 10.6 framework anytime someone wants to use this package. |
|
Does it work outside of nix or is it just broken. |
|
@LnL7 , the package itself will compile/run on a system containing the 10.6 framework (https://forums.wxwidgets.org/viewtopic.php?t=38413) |
|
@LnL7 we might just want to grab this framework file, compile against it, and then delete it. Otherwise, we may install multiple versions of |
|
I would suggest we just mark this as broken on darwin. |
|
I added comment making this Linux-only for now: 8df24b7 |
Motivation for this change
Need to link appropriate services when compiling wxMac 2.8 on Darwin.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)