Allow optional block with Hash#delete #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmulvihill
force-pushed
the
hash-delete
branch
from
cec0be0
to
5548a30
Compare
Sija
reviewed
Jan 8, 2017
| end | ||
| end | ||
|
|
||
| # Deletes the key-value pair and returns the value, else `nil`. |
bmulvihill
force-pushed
the
hash-delete
branch
from
5548a30
to
aee758c
Compare
lbguilherme
reviewed
Jan 8, 2017
| a.delete(3) { found = false } | ||
| found.should be_false | ||
| end | ||
| end |
There was a problem hiding this comment.
Should also spec that the value of the block is returned. And that the method still finds a value if it exists.
|
Should |
bmulvihill
force-pushed
the
hash-delete
branch
from
aee758c
to
4f7eb80
Compare
|
@lbguilherme It should return nil. I switched the implementation so it will only yield if the key is not found, so it now return nil, same as Ruby. I also added 2 more specs as requested |
Sija
reviewed
Jan 8, 2017
| a.delete(1).should eq(2) | ||
| end | ||
|
|
||
| it "executes block if key is not found" do |
There was a problem hiding this comment.
I'd test here case when found key has a nil value, like in { 3 => nil }.delete(3) { 7 }.should be_nil
bmulvihill
force-pushed
the
hash-delete
branch
from
4f7eb80
to
f494b84
Compare
|
@bmulvihill Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby we can pass an optional block to Hash#delete whose result can be returned if a key is not found.
This adds similar functionality to Crystal's Hash#delete.
Thanks!