gtest, gmock: fix broken package by updating to 1.8.0. #21724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivan-tkatchev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @auntieNeo and @vcunat to be potential reviewers. |
ivan-tkatchev
force-pushed
the
pullrequest
branch
3 times, most recently
from
ba6e074
to
7efad58
Compare
ivan-tkatchev
force-pushed
the
pullrequest
branch
from
7efad58
to
9c2a222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current master of nixpkgs has broken gtest and gmock libraries -- Google Code has been taken offline and sources fail to download.
gtest and gmock are now hosted on Github and have been merged into a single library. I've updated the derivations to reflect this.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)