Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quodlibet: rename to quodlibet, quodlibet-without-gst-plugins #22089

Merged
merged 1 commit into from Jan 25, 2017

Conversation

deepfire
Copy link
Contributor

Motivation for this change

The gst-plugin-less version is barely useful out of the box, so it is
the one that should be relegated to a less prominent spot in the namespace.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The gst-plugin-less version is barely useful out of the box, so it is
the one that should be relegated to a less prominent spot in the namespace.
@mention-bot
Copy link

@deepfire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @coroa, @FRidh and @edolstra to be potential reviewers.

@deepfire
Copy link
Contributor Author

cc @coroa

@deepfire
Copy link
Contributor Author

Also, see #21927

@globin globin merged commit 4f8b406 into NixOS:master Jan 25, 2017
@deepfire deepfire deleted the quodlibet-rename branch January 31, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants