Optimize SAO getStaticData by using std::string pointer instead of return copy

nerzhul · nerzhul · commit ef0aa7d5b543 · 2017-01-13T21:56:24.000+01:00
Signed-off-by: Loic Blot &lt;loic.blot@unix-experience.fr&gt;
diff --git a/src/content_sao.cpp b/src/content_sao.cpp
@@ -521,7 +521,7 @@ std::string LuaEntitySAO::getClientInitializationData(u16 protocol_version)
 	return os.str();
 }
 
-std::string LuaEntitySAO::getStaticData() const
+void LuaEntitySAO::getStaticData(std::string *result) const
 {
 	verbosestream<<FUNCTION_NAME<<std::endl;
 	std::ostringstream os(std::ios::binary);
@@ -543,7 +543,7 @@ std::string LuaEntitySAO::getStaticData() const
 	writeV3F1000(os, m_velocity);
 	// yaw
 	writeF1000(os, m_yaw);
-	return os.str();
+	*result = os.str();
 }
 
 int LuaEntitySAO::punch(v3f dir,
@@ -918,10 +918,9 @@ std::string PlayerSAO::getClientInitializationData(u16 protocol_version)
 	return os.str();
 }
 
-std::string PlayerSAO::getStaticData() const
+void PlayerSAO::getStaticData(std::string *result) const
 {
-	FATAL_ERROR("Deprecated function (?)");
-	return "";
+	FATAL_ERROR("Deprecated function");
 }
 
 void PlayerSAO::step(float dtime, bool send_recommended)
diff --git a/src/content_sao.h b/src/content_sao.h
@@ -102,7 +102,7 @@ class LuaEntitySAO : public UnitSAO
 			const std::string &data);
 	void step(float dtime, bool send_recommended);
 	std::string getClientInitializationData(u16 protocol_version);
-	std::string getStaticData() const;
+	void getStaticData(std::string *result) const;
 	int punch(v3f dir,
 			const ToolCapabilities *toolcap=NULL,
 			ServerActiveObject *puncher=NULL,
@@ -199,7 +199,7 @@ class PlayerSAO : public UnitSAO
 	void removingFromEnvironment();
 	bool isStaticAllowed() const { return false; }
 	std::string getClientInitializationData(u16 protocol_version);
-	std::string getStaticData() const;
+	void getStaticData(std::string *result) const;
 	void step(float dtime, bool send_recommended);
 	void setBasePosition(const v3f &position);
 	void setPos(const v3f &pos);
diff --git a/src/serverenvironment.cpp b/src/serverenvironment.cpp
@@ -1694,7 +1694,8 @@ u16 ServerEnvironment::addActiveObjectRaw(ServerActiveObject *object,
 	{
 		// Add static object to active static list of the block
 		v3f objectpos = object->getBasePosition();
-		std::string staticdata = object->getStaticData();
+		std::string staticdata = "";
+		object->getStaticData(&staticdata);
 		StaticObject s_obj(object->getType(), objectpos, staticdata);
 		// Add to the block where the object is located in
 		v3s16 blockpos = getNodeBlockPos(floatToInt(objectpos, BS));
@@ -1980,7 +1981,8 @@ void ServerEnvironment::deactivateFarObjects(bool force_delete)
 					<<std::endl;
 				continue;
 			}
-			std::string staticdata_new = obj->getStaticData();
+			std::string staticdata_new = "";
+			obj->getStaticData(&staticdata_new);
 			StaticObject s_obj(obj->getType(), objectpos, staticdata_new);
 			block->m_static_objects.insert(id, s_obj);
 			obj->m_static_block = blockpos_o;
@@ -2020,7 +2022,8 @@ void ServerEnvironment::deactivateFarObjects(bool force_delete)
 		if(obj->isStaticAllowed())
 		{
 			// Create new static object
-			std::string staticdata_new = obj->getStaticData();
+			std::string staticdata_new = "";
+			obj->getStaticData(&staticdata_new);
 			StaticObject s_obj(obj->getType(), objectpos, staticdata_new);
 
 			bool stays_in_same_block = false;
diff --git a/src/serverobject.h b/src/serverobject.h
@@ -119,10 +119,10 @@ class ServerActiveObject : public ActiveObject
 		when it is created (converted from static to active - actually
 		the data is the static form)
 	*/
-	virtual std::string getStaticData()
+	virtual void getStaticData(std::string *result)
 	{
 		assert(isStaticAllowed());
-		return "";
+		*result = "";
 	}
 	/*
 		Return false in here to never save and instead remove object

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ std::string LuaEntitySAO::getClientInitializationData(u16 protocol_version)`
`521`	`521`	`return os.str();`
`522`	`522`	`}`
`523`	`523`
`524`		`-std::string LuaEntitySAO::getStaticData() const`
	`524`	`+void LuaEntitySAO::getStaticData(std::string *result) const`
`525`	`525`	`{`
`526`	`526`	`verbosestream<<FUNCTION_NAME<<std::endl;`
`527`	`527`	`std::ostringstream os(std::ios::binary);`
`@@ -543,7 +543,7 @@ std::string LuaEntitySAO::getStaticData() const`
`543`	`543`	`writeV3F1000(os, m_velocity);`
`544`	`544`	`// yaw`
`545`	`545`	`writeF1000(os, m_yaw);`
`546`		`- return os.str();`
	`546`	`+ *result = os.str();`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`int LuaEntitySAO::punch(v3f dir,`
`@@ -918,10 +918,9 @@ std::string PlayerSAO::getClientInitializationData(u16 protocol_version)`
`918`	`918`	`return os.str();`
`919`	`919`	`}`
`920`	`920`
`921`		`-std::string PlayerSAO::getStaticData() const`
	`921`	`+void PlayerSAO::getStaticData(std::string *result) const`
`922`	`922`	`{`
`923`		`- FATAL_ERROR("Deprecated function (?)");`
`924`		`- return "";`
	`923`	`+ FATAL_ERROR("Deprecated function");`
`925`	`924`	`}`
`926`	`925`
`927`	`926`	`void PlayerSAO::step(float dtime, bool send_recommended)`
Original file line number	Diff line number	Diff line change
`@@ -119,10 +119,10 @@ class ServerActiveObject : public ActiveObject`
`119`	`119`	`when it is created (converted from static to active - actually`
`120`	`120`	`the data is the static form)`
`121`	`121`	`*/`
`122`		`- virtual std::string getStaticData()`
	`122`	`+ virtual void getStaticData(std::string *result)`
`123`	`123`	`{`
`124`	`124`	`assert(isStaticAllowed());`
`125`		`- return "";`
	`125`	`+ *result = "";`
`126`	`126`	`}`
`127`	`127`	`/*`
`128`	`128`	`Return false in here to never save and instead remove object`