Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update write-mirror-list.sh with idea from issue #8561 #21861

Closed
wants to merge 1 commit into from
Closed

update write-mirror-list.sh with idea from issue #8561 #21861

wants to merge 1 commit into from

Conversation

jpierre03
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jpierre03, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra to be a potential reviewer.

@jpierre03 jpierre03 mentioned this pull request Jan 13, 2017
Closed
@vcunat
Copy link
Member

vcunat commented Jan 13, 2017

For me it fails with egrep or grep -E and succeeds with grep. Nevertheless, it's a really hacky piece of code.

@vcunat
Copy link
Member

vcunat commented Jan 13, 2017

Aha, the suggestion on the issue was slightly different...

@vcunat vcunat closed this in a652099 Jan 13, 2017
@jpierre03 jpierre03 deleted the patch-2 branch January 22, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpierre03 @mention-bot @vcunat