Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: 0.4.6 -> 0.4.8 #21865

Merged
merged 1 commit into from Jan 14, 2017
Merged

solc: 0.4.6 -> 0.4.8 #21865

merged 1 commit into from Jan 14, 2017

Conversation

dbrock
Copy link
Contributor

@dbrock dbrock commented Jan 13, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl merged commit 2dda1ed into NixOS:master Jan 14, 2017
@dbrock dbrock deleted the solc branch January 29, 2017 19:25
@cpages
Copy link
Contributor

cpages commented Feb 3, 2017

Sorry to revive this after merge, but I just found out this fails to build for me with sandboxing enabled. It tries to download jsoncpp during build phase. @dbrock, maybe we're testing under different conditions? Can you verify? Thanks!

@vbgl
Copy link
Contributor

vbgl commented Mar 4, 2017

Thanks for the report, @cpages. Should be fixed by fe0ef55.

@dbrock
Copy link
Contributor Author

dbrock commented Mar 11, 2017

Sorry, missed this. Thanks, @vbgl!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants