Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty class pretty print #3848

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Jan 6, 2017

For example:

class Foo
end

p Foo.new.pretty_inspect # => "#<Foo:0xdeadbeef >"

The result of Foo.new.pretty_inspect contains unnecessary space after address. This pull request fixed it.

@makenowjust
Copy link
Contributor Author

Why CI failed?

@asterite
Copy link
Member

asterite commented Jan 6, 2017

@makenowjust There's something wrong with the travis build for linux 64 bits. I think there's something wrong with the docker image, it seems to be using an old crystal version... but it's strange that it sometimes works.

@asterite
Copy link
Member

asterite commented Jan 6, 2017

Yeah, the docker image for linux 64 bits is old, so using anything "new" (like the overrides? method) will break. This only breaks because we test the method. So for now I'll commit your changes but with the spec commented. We can uncomment it once we release a new version (probably today)

@asterite asterite closed this Jan 6, 2017
@makenowjust
Copy link
Contributor Author

Thanks!

@jhass
Copy link
Member

jhass commented Jan 6, 2017

fwiw I triggered a rebuild of the image, let's see if it helps anything

@makenowjust makenowjust deleted the fix/reference/pretty-print-empty-class branch January 6, 2017 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants