Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: 0.0.11 -> 0.0.13, PaX fix. #21693

Merged
merged 2 commits into from Jan 5, 2017
Merged

discord: 0.0.11 -> 0.0.13, PaX fix. #21693

merged 2 commits into from Jan 5, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 5, 2017 •
edited

Motivation for this change

Update to latest (application apparently refuses to run if not on latest!),
paxmark to allow RWX mapping required for execution.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

grsec warning:

... denied RWX mmap of <anonymous mapping> by /nix/store/sil4wixsg8cig38xbnd0yr82kkpjp41d-discord-0.0.11/DiscordCanary[DiscordCanary:63121]

@mention-bot
Copy link

@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jgeerds, @hedning and @ldesgoui to be potential reviewers.

@jgeerds jgeerds merged commit 40f9eb1 into NixOS:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mention-bot @jgeerds