httpd module: don't create documentRoot directory if it doesn't exist #21703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It hides bugs and do you ever actually want to serve up an empty directory? It was pretty confusing to me when it tried to write into a read-only store path because I accidentally pointed it to the wrong store path.
|
@copumpkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nbp and @aszlig to be potential reviewers. |
|
Also @svanderburg since this is effectively reverting a change he made 6 years ago. |
LnL7
approved these changes
Jan 8, 2017
fpletz
approved these changes
Jan 9, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It hides bugs and do you ever actually want to serve up an empty directory? It was pretty confusing to me when it tried to write into a read-only store path because I accidentally pointed it to the wrong store path.
See #21684 for more discussion.