nginx: add PageSpeed module (Linux only) #21708
Conversation
|
@3noch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @mattbillenstein and @knupfer to be potential reviewers. |
3noch
force-pushed
the
nginx-pagespeed-module
branch
3 times, most recently
from
3ff95fe
to
829e87c
Compare
3noch
changed the title
|
I'm using this module on a staging server with |
| }; | ||
|
|
||
| psol = pkgs.fetchzip { | ||
| url = "https://dl.google.com/dl/page-speed/psol/${version}.tar.gz"; |
There was a problem hiding this comment.
I can't seem to find any license for these binaries. Do you know more?
If we can't distribute these license = pkgs.stdenv.lib.licenses.unfree should added to the meta attribute.
There was a problem hiding this comment.
The AUR people mean it is apache: https://aur.archlinux.org/packages/psol/
In this case there is most likely a LICENSE file in the source tarball.
There was a problem hiding this comment.
It's Apache 2 license. I'll add the meta anyway.
There was a problem hiding this comment.
Is there a better place to put this PSOL library? It really could be used by any package, not just the pagespeed module.
There was a problem hiding this comment.
In fact, I think this same file would be used in the Apache httpd module, so we likely should move this somewhere higher in the package organization.
3noch
force-pushed
the
nginx-pagespeed-module
branch
from
829e87c
to
358331c
Compare
|
Can anyone recommend a better place to put the PSOL package itself? |
|
@3noch in |
3noch
force-pushed
the
nginx-pagespeed-module
branch
from
358331c
to
333cae1
Compare
|
@Mic92 How's this? |
3noch
force-pushed
the
nginx-pagespeed-module
branch
from
333cae1
to
0d4d401
Compare
|
Thanks! |
Motivation for this change
Ref #14277
Fixes #9420
Adds the PageSpeed module for nginx. Currently only Linux is supported because we use the prebuilt PSOL binaries.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)