Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sakura: fixed GLib-GIO-ERROR #21698 #21700

Merged
merged 2 commits into from Jan 7, 2017
Merged

sakura: fixed GLib-GIO-ERROR #21698 #21700

merged 2 commits into from Jan 7, 2017

Conversation

polyrod
Copy link
Contributor

@polyrod polyrod commented Jan 6, 2017

Motivation for this change

Bug Fix for issue; GLib-GIO-ERROR #21698

Things done

added wrapper to sakura binary wich sets path to gtk3-gsettings-schemata which provide
colorchooser fontchooser gui descriptions.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@polyrod, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @grahamc and @astsmtl to be potential reviewers.


postInstall = ''
wrapProgram $out/bin/sakura --suffix XDG_DATA_DIRS : ${gtk3}/share/gsettings-schemas/${gtk3.name}/
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

@FRidh
Copy link
Member

FRidh commented Jan 6, 2017

please squash your commits so that we have only two left, one for sakura and one for chase.

@polyrod
Copy link
Contributor Author

polyrod commented Jan 6, 2017

@FRidh @LnL7 hope its ok like this

@LnL7 LnL7 merged commit 56cceca into NixOS:master Jan 7, 2017
@LnL7
Copy link
Member

LnL7 commented Jan 7, 2017

Thanks!

@not-fl3 not-fl3 mentioned this pull request Mar 21, 2018
8 tasks
@ysndr ysndr mentioned this pull request Jul 24, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants