New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
awscli: 1.11.30 -> 1.11.35 #21611
awscli: 1.11.30 -> 1.11.35 #21611
Conversation
@FRidh TravisCI is not designed to handle this particular pull request. What are we going to do now? |
Just ignore Travis, its not reliable enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me except for the styling issues mentioned below.
url = "mirror://pypi/b/botocore/${name}.tar.gz"; | ||
sha256 = "0fga1zjffsn2h50hbw7s4lcv6zwz5dcjgvjncl5y392mhivlrika"; | ||
}; | ||
version = "1.4.92"; # This version is required by awscli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually indent nix by two spaces, not four spaces. Please restore the original indentation.
description = "Unified tool to manage your AWS services"; | ||
license = stdenv.lib.licenses.asl20; | ||
maintainers = with maintainers; [ muflax ]; | ||
}; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second parenthesis at the end of this line should got to the to the next line. You have seem to merge two lines by accident.
In the past (b2d9b48) I moved |
license = stdenv.lib.licenses.asl20; | ||
maintainers = with maintainers; [ muflax ]; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a few more whitespace errors, then I'll merge :)
@grahamc I did what you asked for. Can you please merge it? |
Merged in 7115ed6, thank you! |
Motivation for this change
Fixes #21591
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)