Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli: 1.11.30 -> 1.11.35 #21611

Closed
wants to merge 3 commits into from
Closed

Conversation

spy-tech
Copy link
Contributor

@spy-tech spy-tech commented Jan 3, 2017

Motivation for this change

Fixes #21591

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@spy-tech, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@spy-tech
Copy link
Contributor Author

spy-tech commented Jan 3, 2017

@FRidh TravisCI is not designed to handle this particular pull request. What are we going to do now?

@FRidh
Copy link
Member

FRidh commented Jan 3, 2017

Just ignore Travis, its not reliable enough.

Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me except for the styling issues mentioned below.

url = "mirror://pypi/b/botocore/${name}.tar.gz";
sha256 = "0fga1zjffsn2h50hbw7s4lcv6zwz5dcjgvjncl5y392mhivlrika";
};
version = "1.4.92"; # This version is required by awscli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually indent nix by two spaces, not four spaces. Please restore the original indentation.

description = "Unified tool to manage your AWS services";
license = stdenv.lib.licenses.asl20;
maintainers = with maintainers; [ muflax ];
}; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second parenthesis at the end of this line should got to the to the next line. You have seem to merge two lines by accident.

@FRidh
Copy link
Member

FRidh commented Jan 3, 2017

In the past (b2d9b48) I moved awscli to python-packages.nix because it is used as a library as well and therefore I removed the namePrefix. This was added back in 323eb06 because when it is used as an application we typically do not include the prefix.

license = stdenv.lib.licenses.asl20;
maintainers = with maintainers; [ muflax ];
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few more whitespace errors, then I'll merge :)

@spy-tech
Copy link
Contributor Author

spy-tech commented Jan 5, 2017

@grahamc I did what you asked for. Can you please merge it?

@FRidh FRidh removed their assignment Jan 5, 2017
@grahamc
Copy link
Member

grahamc commented Jan 6, 2017

Merged in 7115ed6, thank you!

@grahamc grahamc closed this Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants