Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustNightlyBin: 2016-12-05 -> 2016-12-29 #21618

Merged
merged 1 commit into from Jan 3, 2017
Merged

rustNightlyBin: 2016-12-05 -> 2016-12-29 #21618

merged 1 commit into from Jan 3, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 3, 2017

  • add cargo (hence the renaming)
  • also allow to built nix packages
Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
rustNightlyBin: 2016-12-05 -> 2016-12-29
0d689fe 
- add cargo (hence the renaming)
- also allow to built nix packages
@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @qknight to be a potential reviewer.

@qknight qknight merged commit fd152db into NixOS:master Jan 3, 2017
@qknight
Copy link
Member

qknight commented Jan 3, 2017

thanks!

@Mic92 Mic92 deleted the rust branch January 3, 2017 15:52
@sjmackenzie
Copy link
Contributor

excellent cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @mention-bot @qknight @sjmackenzie