Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL::X509::Store doesn't implement the add_path method #1886

Closed
jwinter opened this issue Aug 4, 2014 · 2 comments
Closed

OpenSSL::X509::Store doesn't implement the add_path method #1886

jwinter opened this issue Aug 4, 2014 · 2 comments

Comments

@jwinter
Copy link

jwinter commented Aug 4, 2014

OpenSSL::X509::Store#add_path is unimplemented in JRuby 1.7.13. Store#add_path is a method that accepts a single String argument, a path to a directory full of SSL certs. It adds all the SSL certs it finds in that directory to the store.

MRI implementation is here (if that helps):
https://github.com/ruby/ruby/blob/trunk/ext/openssl/ossl_x509store.c#L238

Current workaround is to create a single .pem file with all of my certs and use Store#add_cert instead.

I hit this issue when using a directory for the value :ssl_ca_cert in my .gemrc like:

:ssl_ca_cert: /path/to-directory/of/ssl-certs/
@jwinter
Copy link
Author

jwinter commented Aug 4, 2014

This is where the X509::Store is defined currently, along with the #add_path unimplemented warning: https://github.com/jruby/jruby-openssl/blob/master/src/main/java/org/jruby/ext/openssl/X509Store.java#L140

@kares kares added the openssl label Apr 9, 2016
@kares
Copy link
Member

kares commented Jan 18, 2017

this has been added since (at some point around jruby-openssl 0.9.12 or so)

@kares kares closed this as completed Jan 18, 2017
@kares kares added this to the Invalid or Duplicate milestone Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants