Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release.nix: Only build bootstrap tools when their system is supported #21971

Merged
merged 1 commit into from Jan 22, 2017
Merged

release.nix: Only build bootstrap tools when their system is supported #21971

merged 1 commit into from Jan 22, 2017

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jan 18, 2017

…is supported

Motivation for this change

Otherwise, hydra will try and build and never be able to.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @domenkozar and @copumpkin to be potential reviewers.

@copumpkin
Copy link
Member

I thought packages only got built on their supported systems. Do the bootstrap tools get treated differently?

@globin globin changed the title release.nix: Only build Only build bootstrap tools when their system … release.nix: Only build bootstrap tools when their system is supported Jan 19, 2017
@grahamc
Copy link
Member Author

grahamc commented Jan 19, 2017 •
edited

They surely do, @copumpkin! The only jobs in the jobs set is set by } // (mapTestOn ((packagePlatforms pkgs) // except for the bootstraps. With the bootstraps hard-coded in to the attrset it puts it in to the queue but can never be built. A separate problem unstable can't be built, due to references to darwin packages...

which makes me wonder if I should make my own release.nix, but if this is true, why have the supportedSystems at all?

@grahamc
Copy link
Member Author

grahamc commented Jan 22, 2017

@copumpkin do you mind merging this?

@globin globin merged commit 13d6681 into NixOS:master Jan 22, 2017
@grahamc grahamc deleted the release-supported-systems branch January 24, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @mention-bot @copumpkin @globin