inkscape: 0.91 -> 0.92 #21765
Merged
inkscape: 0.91 -> 0.92 #21765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @qknight, @DamienCassou and @vbgl to be potential reviewers. |
7c6f434c
requested changes
Jan 9, 2017
| else | ||
| "" | ||
| } | ||
| configurePhase = '' |
There was a problem hiding this comment.
Have you tried not specifying configurePhase? It looks like what would happen by default when you just add cmake to buildInputs (because of a setup-hook in cmake)
| url = "https://inkscape.global.ssl.fastly.net/media/resources/file/" | ||
| + "${name}.tar.bz2"; | ||
| sha256 = "06ql3x732x2rlnanv0a8aharsnj91j5kplksg574090rks51z42d"; | ||
| url = "https://inkscape.org/gallery/item/10552/${name}.0.tar.bz2"; |
There was a problem hiding this comment.
Maybe just ignore the marketing, and call the version is 0.92.0?
|
@7c6f434c amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New features and improvements.
http://wiki.inkscape.org/wiki/index.php/Release_notes/0.92
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Notes: