zlib: Fix zlib.net URL. #21753
Merged
zlib: Fix zlib.net URL. #21753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for primary source file below http://zlib.net/fossils/ as opposed to http://zlib.net/ . zlib-1.2.8.tar.gz is still available at the former location, and will likely remain there. In addition, it's important that the first URL work since zlib is in the bootstrap path, and 16.09 (at least) bootstrap doesn't try to fetch from later ones.
|
It's unfortunate that they don't provide the most current version in the |
|
That would definitely be nice. Still, this is a simple change right now, and IMO a major improvement in keeping this buildable as part of bootstrap; having it broken is causing me major pain (of the "patch local copy of nixpkgs to work around" kind). |
vcunat
pushed a commit
that referenced
this pull request
Jan 8, 2017
Look for primary source file below http://zlib.net/fossils/ as opposed to http://zlib.net/ . zlib-1.2.8.tar.gz is still available at the former location, and will likely remain there. In addition, it's important that the first URL work since zlib is in the bootstrap path, and 16.09 (at least) bootstrap doesn't try to fetch from later ones. (cherry picked from commit d042abe)
|
I'm merging this now to both 16.09 and master. We can always improve further... BTW, this weekend I updated zlib in staging 948e9ed, but it might be necessary to delay that from master for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for primary source file below
http://zlib.net/fossils/ as opposed to
http://zlib.net/
. zlib-1.2.8.tar.gz is still available at the former location, and will likely
remain there. In addition, it's important that the first URL work since zlib
is in the bootstrap path, and 16.09 (at least) bootstrap doesn't try to fetch
from later ones.
Motivation for this change
Bootstrap source tarball fetch is broken due the first URL going dark.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)