Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: Add fedoraproject mirror. #21752

Merged
merged 1 commit into from Jan 8, 2017
Merged

ed: Add fedoraproject mirror. #21752

merged 1 commit into from Jan 8, 2017

Conversation

sh01
Copy link
Contributor

@sh01 sh01 commented Jan 8, 2017

The existing URL has gone dark; this commit adds one from fedoraproject.org
that still works. We put the new mirror first since ed is in the bootstrap
path, and 16.09 bootstrap doesn't try later URLs.

Motivation for this change

Bootstrap source tarball fetch is broken because the existing source URL went dark.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sh01
ed: Add fedoraproject mirror.
547b203 
The existing URL has gone dark; this commit adds one from fedoraproject.org
that still works. We put the new mirror first since ed is in the bootstrap
path, and 16.09 bootstrap doesn't try later URLs.
@mention-bot
Copy link

@sh01, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @edolstra and @wkennington to be potential reviewers.

@matthiasbeyer
Copy link
Contributor

Why does travis fail?

@sh01
Copy link
Contributor Author

sh01 commented Jan 8, 2017

The travis failures are:

  1. "The log length has exceeded the limit of 4 MB".
  2. "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
  3. OSError: [Errno 7] Argument list too long

1 looks like a limitation of the test system and would likely have completed otherwise. Unsure about 2 - I suspect it was just taking more time than planned for - but I don't see how this CL would have caused it.
3. looks like a genuine error on Mac OS, due to some part of the test build overloading some command invocation with more data than the OS supports.

I believe all of these are test infra flakiness and not caused by this change.

@Mic92 Mic92 merged commit c63ebba into NixOS:master Jan 8, 2017
@Mic92
Copy link
Member

Mic92 commented Jan 8, 2017

Thanks!

vcunat added a commit that referenced this pull request Jan 8, 2017
@vcunat
ed: avoid the useless rebuild due to #21752
936bc23
@vcunat
Copy link
Member

vcunat commented Jan 8, 2017 •
edited

This caused a mass rebuild directly on master. I amended the expression so that there's no new attribute exposed to the builder and thus rebuild isn't caused (and cancelled ~32k Hydra jobs).

sh01 pushed a commit to sh01/nixpkgs that referenced this pull request Jan 8, 2017
@vcunat @sh01
ed: avoid the useless rebuild due to NixOS#21752
fd68fbf 
(cherry picked from commit 936bc23)
@sh01 sh01 deleted the ed_mirror branch January 9, 2017 01:30
@matthiasbeyer
Copy link
Contributor

@vcunat can you elaborate why this caused a mass rebuild on master? It seems rather ... surprising to me!

@vcunat
Copy link
Member

vcunat commented Jan 9, 2017

@matthiasbeyer: the new attribute file_md5 passed to mkDerivation is (of course) passed as environment variable to the builder, which is an unpredictable change in principle and requires a rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sh01 @mention-bot @matthiasbeyer @Mic92 @vcunat