Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable failing tests for plugins (microdata, publication_list)
cc @ivanteoh — I don’t understand those tests and failures, so I can’t fix them myself. Signed-off-by: Chris Warrick <kwpolska@gmail.com>
- Loading branch information
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have look them when I got a chance.
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a very different error
E TypeError: compile_html() got an unexpected keyword argument 'post'
when runningtest_publication_list
.773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhdev:
p.compile_html
is an alias forPageCompiler.compile
, whose signature iscompile(self, source, dest, is_two_file=True, post=None, lang=None)
. Maybe you have an older version of Nikola running wherep.compile_html
was still an alias forPageCompiler.compile_html
, whose signature iscompile_html(self, source, dest, is_two_file=True)
(which doesn't expectpost
)?773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strange internal errors in pytest for publication list seem to be caused by a bad design decision in pybtex: they define
__eq__
for their exception class, but not__hash__
. That's pretty annoying. A simplewould have been enough. (Adding that to a local installation should at least allow to get a better error message for the failing tests...)
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfontein Would you mind reporting it to the pybtex issue tracker? I can increase the pybtex minimum requirement for the plugin when it gets into a newer version.
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhdev: if you have an account there, feel free to report that issue yourself. If not, I might do that somewhen later... (I don't have an account there yet.)
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done https://bitbucket.org/pybtex-devs/pybtex/issues/88/the-exception-classes-do-not-have-the
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfontein It's fixed now.
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixfontein Shall we re-enable the tests? A new version of "pybtex" has been released with this fix.
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the tests now don't fail anymore, sure, why not?
@Kwpolska: do you agree?
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhdev If those tests succeed, feel free to move them back to
tests/
and send a PR with that.773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now
test_publication_list
has different error message. Refer to https://travis-ci.org/getnikola/plugins/jobs/208555526. I don't understand much about publication list plugin. I will leave it to the author to resolve the issue.773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand. It seems that somehow the plugin does not have the permission to create the file
output/bibtex/a2015.bib
in the testing environment. Can you help me solving that issue? It works well in my setup.773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhdev it fails in my local setup. What OS is in your setup?
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanteoh I'm on Debian.
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanteoh If you create a dir
output
, the test will pass.773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuhdev
Should use
os.makedirs
instead ofos. mkdir
onBecause
os.makedirs
will create bothoutput
andbibtex
folders, refer to https://docs.python.org/2/library/os.html.Do you want me to update the code and pull request with my code?
773bcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request on #215