Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ed: Merge mirror addition from master #21757

Merged
merged 2 commits into from Jan 8, 2017
Merged

Ed: Merge mirror addition from master #21757

merged 2 commits into from Jan 8, 2017

Conversation

sh01
Copy link
Contributor

@sh01 sh01 commented Jan 8, 2017 •
edited

Motivation for this change

Same as for the original change: Add a mirror for the source tarball that still works.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

sh01 and others added 2 commits January 8, 2017 21:21
@sh01
ed: Add fedoraproject mirror.
9fd495d 
The existing URL has gone dark; this commit adds one from fedoraproject.org
that still works. We put the new mirror first since ed is in the bootstrap
path, and 16.09 bootstrap doesn't try later URLs.

(cherry picked from commit 547b203)
@vcunat @sh01
ed: avoid the useless rebuild due to NixOS#21752
fd68fbf 
(cherry picked from commit 936bc23)
@mention-bot
Copy link

@sh01, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer, @edolstra and @wkennington to be potential reviewers.

@vcunat vcunat merged commit 8a4eae7 into NixOS:release-16.09 Jan 8, 2017
@sh01 sh01 deleted the ed_mirror_16 branch January 9, 2017 01:10
@Mic92 Mic92 mentioned this pull request Jan 14, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sh01 @mention-bot @vcunat