Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroute2: init at 0.4.12 #21869

Merged
merged 1 commit into from Jan 14, 2017
Merged

pyroute2: init at 0.4.12 #21869

merged 1 commit into from Jan 14, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 14, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented Jan 14, 2017

could you put this in a separate nix file in python-modules/

@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2017

Is this the new policy for python packages?

@FRidh
Copy link
Member

FRidh commented Jan 14, 2017

Let's make it a policy. The main file is getting huge and we have to do something about it.

@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2017

@FRidh do you plan to add this to the Contributing Guidelines for python or decide this on a per package base?

@Mic92 Mic92 merged commit be759ba into NixOS:master Jan 14, 2017
@Mic92 Mic92 deleted the pyroute2 branch January 14, 2017 09:21
@FRidh
Copy link
Member

FRidh commented Jan 14, 2017

Would be good to have it in the guidelines, although, many typically don't read the latest version but only the stable one. I would like to have a bot that comments on PR's with notes specific to the files that are touched. That works much better I think.

@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2017

@FRidh bot is good, but I guess this will require some time to setup. Even if they do not read the guidelines immediately, we can quote them in reviews. The next release is although not far away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants