gdm: init at 1.4 #21870
gdm: init at 1.4 #21870
Conversation
|
Does somebody else also gets a "Bad commit or revision" error, when building this package like travis does? |
|
Nitpick: I wonder if gdm might be too ambiguous name; in particular, around Linux packaging this name tends to be mostly associated with gnome display manager – and we use the name as well: |
| src = fetchgit { | ||
| url = "https://github.com/sparrc/gdm"; | ||
| sha256 = "0kpqmbg144qcvd8k88j9yx9lrld85ray2viw161xajafk16plvld"; | ||
| rev = version; |
There was a problem hiding this comment.
Have you tried "refs/tags/${version}", also is there a reason not to use fetchFromGitHub here?
There was a problem hiding this comment.
I think the reason for not using fetchFromGitHub could be how go2nix generated it :-/ I need to implement it there to make maintainers life easier.
There was a problem hiding this comment.
oh, usually I replace fetchgit manually. However in this case I forgot it. @kamilchm if you take a look at how nix-prefetch-zip is implemented, it should be also possible to generate fetchFromGitHub for dependencies (the hash is calculated using the content of the directory, which should be the same as fresh checkout of the local repo). This should you also give a nice speed-up because fetchgit is kind of slow for both downloading and disk i/o.
There was a problem hiding this comment.
I was trying to do it not only for the main source, but for all goDeps #19311
I need to get back to it in near future.
Mic92
force-pushed
the
gdm
branch
2 times, most recently
from
909329b
to
ffe2736
Compare
|
@vcunat I also thought about this one, but did not find a better naming. Are people aware that they have to use modules to install gdm or would it lead to confusion, when they try to add |
|
How about using |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)