Enclose true, false and nil in backquote on document comment #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
suggested changes
Jan 14, 2017
| # * **strict**: if true, extraneous characters past the end of the number are disallowed | ||
| # * **whitespace**: if `true`, leading and trailing whitespaces are allowed | ||
| # * **underscore**: if `true`, underscores in numbers are allowed | ||
| # * **prefix**: if `true`, the prefixes `"0x"`, `"0"` and `"0b"` override the base |
There was a problem hiding this comment.
Wouldn't it be better to remove the double quotes so that: 0x, 0 and 0b
There was a problem hiding this comment.
I think they mean string literal, does not?
There was a problem hiding this comment.
You're absolutely right, thanks for clarifying :).
mverzilli
approved these changes
Jan 14, 2017
|
@mverzilli Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve document ;)