selenium-server-standalone: restore htmlunit-driver support #21868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsenag, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @domenkozar and @utdemir to be potential reviewers. |
Mic92
reviewed
Jan 14, 2017
| homepage = https://github.com/SeleniumHQ/htmlunit-driver; | ||
| description = "A WebDriver server for running Selenium tests on the HtmlUnit headless browser"; | ||
| platforms = platforms.all; | ||
| license = licenses.asl20; |
There was a problem hiding this comment.
it probably make sense to reuse the maintainer of selenium here.
|
|
||
| unpackPhase = "true"; | ||
|
|
||
| buildInputs = [ ]; |
|
|
||
| installPhase = '' | ||
| mkdir -p $out/share/lib/${name} | ||
| cp $src $out/share/lib/${name}/${name}.jar |
There was a problem hiding this comment.
installPhase = "install -D $src $out/share/lib/${name}/${name}.jar";
It was moved to a separate project between versions 2.45 and 2.53: SeleniumHQ/selenium@2d3150b
hsenag
force-pushed
the
htmlunit-driver
branch
from
5276b09
to
f0c230c
Compare
|
@Mic92 thanks, I've updated the commit with your suggestions. |
fpletz
approved these changes
Jan 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was moved to a separate project between versions 2.45 and 2.53:
SeleniumHQ/selenium@2d3150b
Motivation for this change
This restores the previous behaviour of selenium-server-standalone, namely having the HtmlUnit driver available. They've been split into separate projects upstream, but it still makes sense for end users to have the whole package. selenium-server-standalone already depended on chromedriver in a similar way.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)