New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #201 #202
fix #201 #202
Conversation
Thanks for this! Please could you:
|
Also, the line in .travis.yml which installes a recent E::P is no longer needed.
@mohawk2, Thanks for the quick reply! The indentation is fixed now. Why should we duplicate the E::P requirement in BUILD_REQUIRES? From CPAN::Meta::Spec#Phases it seems that config requirements automatically apply to the build phase also. |
I think I experienced an issue with that in @devel-chm if you agree, want to merge? @amba If you feel that this would fix #201, want to use a fancy GH feature and edit either the PR title or opening comment to say "fix #201"? |
I can't figure out how to get the fix from github to apply to the sf.net repo. Is there a way to get the change as a patch that could be applied to sf.net pdl master? |
That's a good question. If you look on the "Merge pull request" section of this page, you'll see a link to "view command line instructions". The title is "Merging via command line", and the commands I believe you'll want are:
|
Shell I provide a patch also? @mohawk2 @devel-chm |
@amba That shouldn't be necessary. @devel-chm any problems with the ideas above? |
The last time I tried to rebase the fix to the lastest master there were a number of merge conflicts which I haven't had time to look at or to figure out if I was doing something wrong. I should have some more time no later than this weekend. Of course with a ff-only compliant patch this would be done in a jiffy. |
Thanks for the pointers. I got confused with which master was which... |
appveyor build is failing for strawberry perl. |
That looks to be an issue unrelated to this one, as it's some kind of tool for installing strawberry that's failing because of missing checksums. |
No description provided.