Fix #2628 - allow meta generator to be diabled #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
previously requested changes
Jan 14, 2017
| @@ -11,6 +11,8 @@ Features | |||
| * Sort posts in the following order (most important last): source path | |||
| (A-Z), title (A-Z), date (reverse chronological order), priority | |||
| meta number (descending). (Issue #2627) | |||
| * Add META_GENERATOR_TAG option in conf.py allowing the meta generator | |||
| to be disabled if needed. (Issue #2628) | |||
There was a problem hiding this comment.
You need to add this more at the top, before the changelist for version v7.8.3 starts. Now it looks like this was added in v7.8.3, while it wasn't.
Just start an empty Features section at the top of the file and move the comment there.
There was a problem hiding this comment.
@felixfontein This should be the entire New in master/Features/Bugfixes template. I’ll take care of it myself, it’s a pretty minor thing.
Kwpolska
approved these changes
Jan 14, 2017
Kwpolska
dismissed
felixfontein’s stale review
This is so minor that I’ll fix it myself, so no need to withhold this PR.
|
Sure, fine for me :) |
|
Thanks @adarshdec23 for implementing this! |
|
Thanks for contributing to Nikola, @adarshdec23! |
Kwpolska
added a commit
that referenced
this pull request
Jan 14, 2017
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
Thanks for the merge! :-) |
felixfontein
added a commit
that referenced
this pull request
Jan 14, 2017
felixfontein
added a commit
that referenced
this pull request
Jan 14, 2017
Still missing from #2634.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.