crystal: fix build in chroot environment, again #21453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgot to patch interpreter of the script used by Makefile, carefully ensure it can build without /usr/bin/env this time.
|
I've recently tested this patch and now crystal is compiling without any break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
After last pr (#21428) being merged into master, hydra still failed to build crystal,
then I realized that forgot to patch another script used by Makefile.
(I test last pr with nix.useSandbox = true, it succeed to build locally, strange..)
This time I'm sure it can be build without /usr/bin/env,
but to make sure everything works after this pr,
@mimadrid I would be very appreciated if you can also test this pr to ensure everything works with nix.useSandbox = true, and to avoid I made any silly mistake again, thank you!
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)