syncthing-gtk: 0.6.3 -> 0.9.2.3 #21446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have made some changes there, so I would welcome any review, particularly coming from maintainers of Python+GTK packages. I would like comments most for:
|
7 tasks
LnL7
approved these changes
Dec 30, 2016
LnL7
reviewed
Dec 30, 2016
| pygobject3 pkgs.gtk3 ]; | ||
| propagatedBuildInputs = with self; [ pkgs.syncthing dateutil pyinotify | ||
| pkgs.libnotify | ||
| (pkgs.librsvg.override rec { withGTK = true; }) |
There was a problem hiding this comment.
Thanks, I have just removed it.
jokogr
force-pushed
the
u/syncthing-gtk-0.9.2.3
branch
from
951d3a8
to
dc70cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A test in the stable release branch was failing and thought to update it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)