Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorilla-bin: init at 1.5.3.7 #21449

Merged
merged 4 commits into from Dec 30, 2016
Merged

gorilla-bin: init at 1.5.3.7 #21449

merged 4 commits into from Dec 30, 2016

Conversation

namore
Copy link
Contributor

@namore namore commented Dec 27, 2016

Motivation for this change

Add password manager "gorilla" (currently available for various operating systems, e.g., Debian or FreeBSD, but not yet nix*).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
Caveats

Only 64 bit Linux platform supported, since package is based on binary version.


@mention-bot
Copy link

@namore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @edolstra to be potential reviewers.

@7c6f434c
Copy link
Member

Is the build process complicated? Maybe call this gorilla-bin?

@namore
Copy link
Contributor Author

namore commented Dec 28, 2016

@7c6f434c, I followed your advice and postfixed the package name to gorilla-bin.

Also: yes, I consider the build process rather complex for nix (e.g., binary shared objects in the source tree for common platforms..).

@namore namore changed the title gorilla: init at 1.5.3.7 gorilla-bin: init at 1.5.3.7 Dec 28, 2016
@namore
Copy link
Contributor Author

namore commented Dec 29, 2016

If I interpret the CI build logs correctly, gtk requires a rebuild from source currently, which causes log files that exceed the 4mb limit. The other tests passed, so I suppose everything is working.

@7c6f434c 7c6f434c merged commit 6fef7f1 into NixOS:master Dec 30, 2016
@7c6f434c
Copy link
Member

Wait, wait, precompiled shared objects in the source tree do not sound like a source build… Is there a way to actually build it from actual source?

@namore
Copy link
Contributor Author

namore commented Jan 4, 2017

@7c6f434c, it is possible. They just bundle dependencies at specific versions as binaries for convenience. Also, the documentation points out that while it is possible to use a system-wide installed version of these dependencies, "the exact details of how to do so are beyond the scope of [the documentation] and are left up to those with sufficient knowledge of the Tcl package system."
Even more warning: "installing all packages globally is untested, and as such your
mileage may vary if you do attempt to do such an install."
In summary, I suppose it's easiest/safest to stick with the gorilla-bin package for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants