gphoto2: nixos programs module to configure udev #21444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@league, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
league
force-pushed
the
fix/gphoto2-udev
branch
from
052da9e
to
3e1cb02
Compare
|
I'd just add the udev rules to the original gphoto2 package (instead of separate package). Otherwise it looks good to me. |
league
force-pushed
the
fix/gphoto2-udev
branch
from
3e1cb02
to
6eead52
Compare
|
@bjornfor Thanks for the suggestion. Latest commit does just that. Wait for Travis, and then ready to merge, AFAICT. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21420.
Motivation for this change
See #21420: I plugged in my digital camera and could not run
gphoto2to download images as regular user due to insufficient permissions. This adds a NixOS optionprograms.gphoto2.enablethat installs not justgphoto2, but also a file of udev rules for setting the group ownership of a plugged-in camera tocamera.Tested on my NixOS 16.09.git.9db36f2 and then applied changes to master.
First contribution, happy to learn and fix anything to follow standards better.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)